Omar, On 5/16/22 23:23, Shinichiro Kawasaki wrote: > On May 16, 2022 / 15:55, Alan Adamson wrote: >> Test nvme error logging by injecting errors. Kernel must have FAULT_INJECTION >> and FAULT_INJECTION_DEBUG_FS configured to use error injector. Tests can be >> run with or without NVME_VERBOSE_ERRORS configured. >> >> These test verify the functionality delivered by the follow: >> commit bd83fe6f2cd2 ("nvme: add verbose error logging") >> >> V2 - Update from suggestions from shinichiro.kawasaki@xxxxxxx >> V3 - Add error injector helper functions to nvme/rc >> V4 - Comments from shinichiro.kawasaki@xxxxxxx >> >> Alan Adamson (2): >> tests/nvme: add helper routine to use error injector >> tests/nvme: add tests for error logging > > Thanks for the updates. For the series, > > Reviewed-by: Shin'ichiro Kawasaki <shinichiro.kawasaki@xxxxxxx> > Whenever you get some free time it will be great to have this in the repo so other distros can pull these changes. -ck