Re: Issue with 252c651a4c85 ("blk-cgroup: stop using seq_get_buf")

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Thu, May 12, 2022 at 03:42:54PM -0700, Khazhy Kumykov wrote:
> I can see in the latest tip, if we have devices with no statistics,
> we'll print the maj:min and then nothing else, which can end up
> looking weird, (e.g. like below.) I see that in older kernels, we
> avoided printing the device name at all if there were no stats, and it
> looks like this behavior was silently broken by 252c651a4c85
> ("blk-cgroup: stop using seq_get_buf"), where before we prepared the
> whole line then decided at the end whether to commit it or not.
> 
> I do see a patch "blk-cgroup: always terminate io.stat lines" that
> addresses this by just unconditionally printing the newline (though it
> looks like that patch never landed).

It should really go in, I just sent a ping for it.



[Index of Archives]     [Linux RAID]     [Linux SCSI]     [Linux ATA RAID]     [IDE]     [Linux Wireless]     [Linux Kernel]     [ATH6KL]     [Linux Bluetooth]     [Linux Netdev]     [Kernel Newbies]     [Security]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Device Mapper]

  Powered by Linux