Re: [PATCH] block: cleanup the VM accounting in submit_bio

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

To: Christoph Hellwig <hch@xxxxxx>, Damien Le Moal <damien.lemoal@xxxxxxxxxxxxxxxxxx>
Subject: Re: [PATCH] block: cleanup the VM accounting in submit_bio
From: Jens Axboe <axboe@xxxxxxxxx>
Date: Mon, 16 May 2022 11:37:08 -0600
Cc: linux-block@xxxxxxxxxxxxxxx
In-reply-to: <20220516141141.GA11736@lst.de>
References: <20220516063654.2782792-1-hch@lst.de> <43ae0d52-9ed7-757c-4a01-4b4ca71a00ba@opensource.wdc.com> <20220516141141.GA11736@lst.de>
User-agent: Mozilla/5.0 (X11; Linux aarch64; rv:91.0) Gecko/20100101 Thunderbird/91.8.1

On 5/16/22 8:11 AM, Christoph Hellwig wrote:
> On Mon, May 16, 2022 at 03:45:08PM +0200, Damien Le Moal wrote:
>> I know it is the same value, but for consistency, wouldn't it be better to use
>> REQ_OP_WRITE here ?
> 
> Yes, it absolutely would.  The use of WRITE wasn't even initentional.

I'll fix it up.

-- 
Jens Axboe

References:
- [PATCH] block: cleanup the VM accounting in submit_bio
  - From: Christoph Hellwig
- Re: [PATCH] block: cleanup the VM accounting in submit_bio
  - From: Damien Le Moal
- Re: [PATCH] block: cleanup the VM accounting in submit_bio
  - From: Christoph Hellwig

Prev by Date: [PATCH v4 12/13] null_blk: use zone_size_sects_shift for power of 2 zoned devices
Next by Date: Re: [PATCH -next v2 0/2] block, bfq: make bfq_has_work() more accurate
Previous by thread: Re: [PATCH] block: cleanup the VM accounting in submit_bio
Next by thread: [PATCH] blk-iocost: fix very large vtime when iocg activate
Index(es):
- Date
- Thread

[Index of Archives] [Linux RAID] [Linux SCSI] [Linux ATA RAID] [IDE] [Linux Wireless] [Linux Kernel] [ATH6KL] [Linux Bluetooth] [Linux Netdev] [Kernel Newbies] [Security] [Git] [Netfilter] [Bugtraq] [Yosemite News] [MIPS Linux] [ARM Linux] [Linux Security] [Device Mapper]

Powered by Linux