On 5/10/2022 4:03 PM, Jens Axboe wrote: > On 5/10/22 7:00 AM, Christoph Hellwig wrote: >> Keep the op-specific flag last. > > Not that I'm against the patch, but we really should have some > justification in the commit message as to why the change is > useful or needed. > Something like following might be useful :- "Currently we support seven request flags out of which only __REQ_NOUNMAP is used with REQ_OP_WRITE_ZEROES, rest of the flags are not necessarily associated with specific REQ_OP_XXX. Instead of mixing the request specific flags with the non-request specific flags, move request specific flags __REQ_NOUNMAP at the end for better readability so future request specific flags can go at the end." Full disclosure I've not verified other flags. -ck
