Randy Dunlap <rdunlap@xxxxxxxxxxxxx> writes: > On 5/9/22 02:23, Ming Lei wrote: >> diff --git a/drivers/block/Kconfig b/drivers/block/Kconfig >> index fdb81f2794cd..3893ccd82e8a 100644 >> --- a/drivers/block/Kconfig >> +++ b/drivers/block/Kconfig >> @@ -408,6 +408,13 @@ config BLK_DEV_RBD >> >> If unsure, say N. >> >> +config BLK_DEV_USER_BLK_DRV >> + bool "Userspace block driver" >> + select IO_URING >> + default y > > Any "default y" driver is highly questionable and needs to be justified. > > Also: why is it bool instead of tristate? I think it's only bool because it depends on task_work_add, which is not exported to modules. It is something to be fixed for sure, can that function just be exported? -- Gabriel Krisman Bertazi