Hi Damien, On 2022-04-28 23:49, Damien Le Moal wrote: > This is still not convincing given the code I saw. Additional test cases > need to be added with data verification & concurrent regular writes also > sent while doing copy to verify locking. > > Which also reminds me that I have not seen any change to mq-deadline zone > write locking for this series. What is the assumption ? That users should > not be issuing writes when a copy is on-going ? What a bout the reverse > case ? at the very least, it seems that blk_issue_copy() should be taking > the zone write lock. > I think you posted this comment in this thread instead of posting it in the copy offload thread. >> I will make sure to add my private tree for zonefs in my cover letter in >> the next rev. But even without that change, a typical emulated npo2 >> device should work fine because the changes are applicable only for >> "runt" zones. > >
