On Wed, Apr 27, 2022 at 09:24:34AM -0400, Paul Gortmaker wrote: > These were only implemented by the IDE CD driver, which has since > been removed. Given that nobody is likely to create new CD/DVD > hardware (and associated drivers) we can mark these appropriately. > > Cc: Jens Axboe <axboe@xxxxxxxxx> > Cc: Christoph Hellwig <hch@xxxxxx> > Cc: Phillip Potter <phil@xxxxxxxxxxxxxxxx> > Signed-off-by: Paul Gortmaker <paul.gortmaker@xxxxxxxxxxxxx> > --- > Documentation/userspace-api/ioctl/cdrom.rst | 6 ++++++ > include/uapi/linux/cdrom.h | 2 +- > 2 files changed, 7 insertions(+), 1 deletion(-) > > diff --git a/Documentation/userspace-api/ioctl/cdrom.rst b/Documentation/userspace-api/ioctl/cdrom.rst > index 682948fc88a3..2ad91dbebd7c 100644 > --- a/Documentation/userspace-api/ioctl/cdrom.rst > +++ b/Documentation/userspace-api/ioctl/cdrom.rst > @@ -718,6 +718,9 @@ CDROMPLAYBLK > > > CDROMGETSPINDOWN > + Obsolete, was ide-cd only > + > + > usage:: > > char spindown; > @@ -736,6 +739,9 @@ CDROMGETSPINDOWN > > > CDROMSETSPINDOWN > + Obsolete, was ide-cd only > + > + > usage:: > > char spindown > diff --git a/include/uapi/linux/cdrom.h b/include/uapi/linux/cdrom.h > index 804ff8d98f71..011e594e4a0d 100644 > --- a/include/uapi/linux/cdrom.h > +++ b/include/uapi/linux/cdrom.h > @@ -103,7 +103,7 @@ > #define CDROMREADALL 0x5318 /* read all 2646 bytes */ > > /* > - * These ioctls are (now) only in ide-cd.c for controlling > + * These ioctls were only in (now removed) ide-cd.c for controlling > * drive spindown time. They should be implemented in the > * Uniform driver, via generic packet commands, GPCMD_MODE_SELECT_10, > * GPCMD_MODE_SENSE_10 and the GPMODE_POWER_PAGE... > -- > 2.33.0 > Same for this one, looks good, will send on. Many thanks. Signed-off-by: Phillip Potter <phil@xxxxxxxxxxxxxxxx> Regards, Phil
