On 4/23/22 09:50, Christoph Hellwig wrote: > On Fri, Apr 22, 2022 at 08:06:33AM -0700, Luis Chamberlain wrote: >> It begs the question if the same wish should apply to fstests. > > xfstests generally works fine except for a handful test that explicitly > want module removal but _notrun gracefully in that case. Unlike > blktests which just explodes. > >> If we want to *not* rely on module removal then the right thing to do I >> think would be to replace module removal on these debug modules >> (scsi_debug) with an API as null_blk has which uses configfs to *add* / >> *remove* devices. > > scsi_debug has runtime writable module parameters that cover just > about everything. > I've added to the my TODO list making nvme-blktests where we can avoid the need for module loading and unloading, I'll also add a module load-unload specific tests to that functionality will get tested. -ck
