On 4/20/22 08:04, Stefan Hajnoczi wrote: > On Tue, Apr 19, 2022 at 09:10:51PM -0700, Chaitanya Kulkarni wrote: >> Don't split sector assignment line for REQ_OP_READ and REQ_OP_WRITE in >> the virtblk_setup_cmd() which fits in one line perfectly. >> >> Signed-off-by: Chaitanya Kulkarni <kch@xxxxxxxxxx> >> --- >> drivers/block/virtio_blk.c | 6 ++---- >> 1 file changed, 2 insertions(+), 4 deletions(-) > > There is a cost to patches: humans spend time reviewing them, CI systems > consume energy running tests, downstream maintainers deal with > backports, and git-blame(1) becomes harder to use when code changes. > > What constitutes code churn is subjective. For me personally I prefer it > when patches have a clear benefit that outweighs the costs. > Nevertheless: > > Reviewed-by: Stefan Hajnoczi <stefanha@xxxxxxxxxx> > maybe we can just drop it then, for naked eye it looked a bit odd to add a new line.. -ck
