Hi Ming, Thank you for the patch! Perhaps something to improve: [auto build test WARNING on axboe-block/for-next] [also build test WARNING on v5.18-rc3 next-20220421] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use '--base' as documented in https://git-scm.com/docs/git-format-patch] url: https://github.com/intel-lab-lkp/linux/commits/Ming-Lei/block-fix-Directory-XXXXX-with-parent-block-already-present/20220421-163556 base: https://git.kernel.org/pub/scm/linux/kernel/git/axboe/linux-block.git for-next config: csky-randconfig-r036-20220421 (https://download.01.org/0day-ci/archive/20220422/202204220422.9SM0r5ue-lkp@xxxxxxxxx/config) compiler: csky-linux-gcc (GCC) 11.2.0 reproduce (this is a W=1 build): wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross chmod +x ~/bin/make.cross # https://github.com/intel-lab-lkp/linux/commit/746684a4668ee70b284126159a10f98ff7ebb319 git remote add linux-review https://github.com/intel-lab-lkp/linux git fetch --no-tags linux-review Ming-Lei/block-fix-Directory-XXXXX-with-parent-block-already-present/20220421-163556 git checkout 746684a4668ee70b284126159a10f98ff7ebb319 # save the config file mkdir build_dir && cp config build_dir/.config COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-11.2.0 make.cross W=1 O=build_dir ARCH=csky SHELL=/bin/bash If you fix the issue, kindly add following tag as appropriate Reported-by: kernel test robot <lkp@xxxxxxxxx> All warnings (new ones prefixed by >>): block/blk-sysfs.c: In function 'blk_register_queue': >> block/blk-sysfs.c:841:43: warning: passing argument 4 of 'debugfs_rename' discards 'const' qualifier from pointer target type [-Wdiscarded-qualifiers] 841 | blk_debugfs_root, kobject_name(q->kobj.parent)); | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~ In file included from block/blk-sysfs.c:13: include/linux/debugfs.h:252:47: note: expected 'char *' but argument is of type 'const char *' 252 | struct dentry *new_dir, char *new_name) | ~~~~~~^~~~~~~~ vim +841 block/blk-sysfs.c 808 809 /** 810 * blk_register_queue - register a block layer queue with sysfs 811 * @disk: Disk of which the request queue should be registered with sysfs. 812 */ 813 int blk_register_queue(struct gendisk *disk) 814 { 815 int ret; 816 struct device *dev = disk_to_dev(disk); 817 struct request_queue *q = disk->queue; 818 819 ret = blk_trace_init_sysfs(dev); 820 if (ret) 821 return ret; 822 823 mutex_lock(&q->sysfs_dir_lock); 824 825 ret = kobject_add(&q->kobj, kobject_get(&dev->kobj), "%s", "queue"); 826 if (ret < 0) { 827 blk_trace_remove_sysfs(dev); 828 goto unlock; 829 } 830 831 ret = sysfs_create_group(&q->kobj, &queue_attr_group); 832 if (ret) { 833 blk_trace_remove_sysfs(dev); 834 kobject_del(&q->kobj); 835 kobject_put(&dev->kobj); 836 goto unlock; 837 } 838 839 mutex_lock(&q->debugfs_mutex); 840 q->debugfs_dir = debugfs_rename(blk_debugfs_root, q->debugfs_dir, > 841 blk_debugfs_root, kobject_name(q->kobj.parent)); 842 mutex_unlock(&q->debugfs_mutex); 843 844 if (queue_is_mq(q)) { 845 __blk_mq_register_dev(dev, q); 846 blk_mq_debugfs_register(q); 847 } 848 849 mutex_lock(&q->sysfs_lock); 850 851 ret = disk_register_independent_access_ranges(disk, NULL); 852 if (ret) 853 goto put_dev; 854 855 if (q->elevator) { 856 ret = elv_register_queue(q, false); 857 if (ret) 858 goto put_dev; 859 } 860 861 ret = blk_crypto_sysfs_register(q); 862 if (ret) 863 goto put_dev; 864 865 blk_queue_flag_set(QUEUE_FLAG_REGISTERED, q); 866 wbt_enable_default(q); 867 blk_throtl_register_queue(q); 868 869 /* Now everything is ready and send out KOBJ_ADD uevent */ 870 kobject_uevent(&q->kobj, KOBJ_ADD); 871 if (q->elevator) 872 kobject_uevent(&q->elevator->kobj, KOBJ_ADD); 873 mutex_unlock(&q->sysfs_lock); 874 875 unlock: 876 mutex_unlock(&q->sysfs_dir_lock); 877 878 /* 879 * SCSI probing may synchronously create and destroy a lot of 880 * request_queues for non-existent devices. Shutting down a fully 881 * functional queue takes measureable wallclock time as RCU grace 882 * periods are involved. To avoid excessive latency in these 883 * cases, a request_queue starts out in a degraded mode which is 884 * faster to shut down and is made fully functional here as 885 * request_queues for non-existent devices never get registered. 886 */ 887 if (!blk_queue_init_done(q)) { 888 blk_queue_flag_set(QUEUE_FLAG_INIT_DONE, q); 889 percpu_ref_switch_to_percpu(&q->q_usage_counter); 890 } 891 892 return ret; 893 894 put_dev: 895 elv_unregister_queue(q); 896 disk_unregister_independent_access_ranges(disk); 897 mutex_unlock(&q->sysfs_lock); 898 mutex_unlock(&q->sysfs_dir_lock); 899 kobject_del(&q->kobj); 900 blk_trace_remove_sysfs(dev); 901 kobject_put(&dev->kobj); 902 903 return ret; 904 } 905 -- 0-DAY CI Kernel Test Service https://01.org/lkp
