On Thu, Apr 21, 2022 at 1:35 AM Ming Lei <ming.lei@xxxxxxxxxx> wrote: > > q->debugfs_dir is used by blk-mq debugfs and blktrace. The dentry is > created when adding disk, and removed when releasing request queue. > > There is small window between releasing disk and releasing request > queue, and during the period, one disk with same name may be created > and added, so debugfs_create_dir() may complain with "Directory XXXXX > with parent 'block' already present!" > > Fixes the issue by moving debugfs_create_dir() into blk_alloc_queue(), > and the dir name is named with q->id from beginning, and switched to > disk name when adding disk, and finally changed to q->id in disk_release(). Oh, I thought this was already addressed here?: https://lore.kernel.org/all/20220415035607.1836495-1-yukuai3@xxxxxxxxxx/
