On 4/15/22 20:06, Bart Van Assche wrote:
On 4/14/22 22:58, Chaitanya Kulkarni wrote:
If it doesn't add a new test coverage in the blktest framework
then please remove.
cd blktests && git grep -nH dev/nvme-fabrics
tests/nvmeof-mp/rc:94: [ -c /dev/nvme-fabrics ] &&
tests/nvmeof-mp/rc:101: echo -n "$loginparams" >
/dev/nvme-fabrics
tests/nvmeof-mp/rc:161: if [ ! -c /dev/nvme-fabrics ]; then
tests/nvmeof-mp/rc:162: echo "Error: /dev/nvme-fabrics not
available"
Does this mean that there are no other tests in the blktests framework that
test NVMeOF and hence that it is useful to keep these tests?
# git grep _nvme_connect_subsys
tests/nvme/003: _nvme_connect_subsys "${nvme_trtype}"
nqn.2014-08.org.nvmexpress.discovery
tests/nvme/004: _nvme_connect_subsys "${nvme_trtype}" blktests-subsystem-1
tests/nvme/005: _nvme_connect_subsys "${nvme_trtype}" blktests-subsystem-1
tests/nvme/008: _nvme_connect_subsys "${nvme_trtype}" "${subsys_name}"
tests/nvme/009: _nvme_connect_subsys "${nvme_trtype}" "${subsys_name}"
tests/nvme/010: _nvme_connect_subsys "${nvme_trtype}" "${subsys_name}"
tests/nvme/011: _nvme_connect_subsys "${nvme_trtype}" "${subsys_name}"
tests/nvme/012: _nvme_connect_subsys "${nvme_trtype}" "${subsys_name}"
tests/nvme/013: _nvme_connect_subsys "${nvme_trtype}" "${subsys_name}"
tests/nvme/014: _nvme_connect_subsys "${nvme_trtype}" "${subsys_name}"
tests/nvme/015: _nvme_connect_subsys "${nvme_trtype}" "${subsys_name}"
tests/nvme/018: _nvme_connect_subsys "${nvme_trtype}" "${subsys_name}"
tests/nvme/019: _nvme_connect_subsys "${nvme_trtype}" "${subsys_name}"
tests/nvme/020: _nvme_connect_subsys "${nvme_trtype}" "${subsys_name}"
tests/nvme/021: _nvme_connect_subsys "${nvme_trtype}" "${subsys_name}"
[ .. ]
So: no, it just means you've been using the wrong filter.
Cheers,
Hannes
--
Dr. Hannes Reinecke Kernel Storage Architect
hare@xxxxxxx +49 911 74053 688
SUSE Software Solutions Germany GmbH, Maxfeldstr. 5, 90409 Nürnberg
HRB 36809 (AG Nürnberg), GF: Felix Imendörffer
