On Mon, Apr 18, 2022 at 03:27:16PM -0700, Eric Biggers wrote: > > When I test fscrypt first, it make me confused. Not a real problem, just make this logical more reasonable. > > Do you think this needs to be revised? > > Well, I'm just not sure we should do this, or at least by itself, given that > support for inline encryption is not an either-or thing, and the inlinecrypt > mount option is already documented to apply only to files where inline > encryption can be used. Indeed; some encryption algorithms won't be available because they weren't compiled into the kernel; others because block device for a particular file system doesn't support inline crypto. It seems to me that the test or the test runner should be able to figure this out. It should be able to explicitly try to set a particular policy, and if that policy fails, it should give an intelligent message, e.g., "Skipping this test config because inline-crypto isn't supported." Why can't we fix this in the test runner's scripts? - Ted
