Re: [Ocfs2-devel] [PATCH 19/27] block: remove queue_discard_alignment

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

To: Christoph Hellwig via Ocfs2-devel <ocfs2-devel@xxxxxxxxxxxxxx>
Subject: Re: [Ocfs2-devel] [PATCH 19/27] block: remove queue_discard_alignment
From: "Martin K. Petersen" <martin.petersen@xxxxxxxxxx>
Date: Wed, 06 Apr 2022 23:21:43 -0400
Cc: Jens Axboe <axboe@xxxxxxxxx>, Christoph Hellwig <hch@xxxxxx>, jfs-discussion@xxxxxxxxxxxxxxxxxxxxx, linux-nvme@xxxxxxxxxxxxxxxxxxx, virtualization@xxxxxxxxxxxxxxxxxxxxxxxxxx, linux-mm@xxxxxxxxx, dm-devel@xxxxxxxxxx, target-devel@xxxxxxxxxxxxxxx, linux-mtd@xxxxxxxxxxxxxxxxxxx, drbd-dev@xxxxxxxxxxxxxxxx, linux-s390@xxxxxxxxxxxxxxx, linux-nilfs@xxxxxxxxxxxxxxx, linux-scsi@xxxxxxxxxxxxxxx, cluster-devel@xxxxxxxxxx, xen-devel@xxxxxxxxxxxxxxxxxxxx, linux-ext4@xxxxxxxxxxxxxxx, linux-um@xxxxxxxxxxxxxxxxxxx, nbd@xxxxxxxxxxxxxxxx, linux-block@xxxxxxxxxxxxxxx, linux-bcache@xxxxxxxxxxxxxxx, ceph-devel@xxxxxxxxxxxxxxx, linux-raid@xxxxxxxxxxxxxxx, linux-mmc@xxxxxxxxxxxxxxx, linux-f2fs-devel@xxxxxxxxxxxxxxxxxxxxx, linux-xfs@xxxxxxxxxxxxxxx, linux-fsdevel@xxxxxxxxxxxxxxx, ntfs3@xxxxxxxxxxxxxxx, linux-btrfs@xxxxxxxxxxxxxxx
In-reply-to: <20220406060516.409838-20-hch@lst.de> (Christoph Hellwig via Ocfs2-devel's message of "Wed, 6 Apr 2022 08:05:08 +0200")
Organization: Oracle Corporation
References: <20220406060516.409838-1-hch@lst.de> <20220406060516.409838-20-hch@lst.de>

Christoph,

> Just use bdev_alignment_offset in disk_discard_alignment_show instead.
> That helpers is the same except for an always false branch that
> doesn't matter in this slow path.

Reviewed-by: Martin K. Petersen <martin.petersen@xxxxxxxxxx>

-- 
Martin K. Petersen	Oracle Linux Engineering

References:
- use block_device based APIs in block layer consumers
  - From: Christoph Hellwig
- [PATCH 19/27] block: remove queue_discard_alignment
  - From: Christoph Hellwig

Prev by Date: Re: [Ocfs2-devel] [PATCH 18/27] block: move bdev_alignment_offset and queue_limit_alignment_offset out of line
Next by Date: Re: [Ocfs2-devel] [PATCH 20/27] block: use bdev_discard_alignment in part_discard_alignment_show
Previous by thread: [PATCH 19/27] block: remove queue_discard_alignment
Next by thread: [PATCH 25/27] block: remove QUEUE_FLAG_DISCARD
Index(es):
- Date
- Thread

[Index of Archives] [Linux RAID] [Linux SCSI] [Linux ATA RAID] [IDE] [Linux Wireless] [Linux Kernel] [ATH6KL] [Linux Bluetooth] [Linux Netdev] [Kernel Newbies] [Security] [Git] [Netfilter] [Bugtraq] [Yosemite News] [MIPS Linux] [ARM Linux] [Linux Security] [Device Mapper]