Re: [PATCH blktests] nvme tests should use nvme_trtype when setting up passthru target

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 




> On Mar 31, 2022, at 2:45 PM, Alan Adamson <ALAN.ADAMSON@xxxxxxxxxx> wrote:
> 
> No matter what was passed in with nvme_trtype, the target was being
> set up with trtype as "loop".  This caused several passthru tests
> to fail when testing tcp or rdma.
> 
> Signed-off-by: Alan Adamson <alan.adamson@xxxxxxxxxx>
> ---
> tests/nvme/rc | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/tests/nvme/rc b/tests/nvme/rc
> index 1c27cdee1b5f..3c38408a0bfe 100644
> --- a/tests/nvme/rc
> +++ b/tests/nvme/rc
> @@ -335,7 +335,7 @@ _nvmet_passthru_target_setup() {
> 	local subsys_name=$1
> 
> 	_create_nvmet_passthru "${subsys_name}"
> -	port="$(_create_nvmet_port "loop")"
> +	port="$(_create_nvmet_port "${nvme_trtype}")"
> 	_add_nvmet_subsys_to_port "${port}" "${subsys_name}"
> 
> 	echo "$port"
> -- 
> 2.27.0
> 

Looks Good

Reviewed-by: Himanshu Madhani <himanshu.madhani@xxxxxxxxxx>

--
Himanshu Madhani	 Oracle Linux Engineering





[Index of Archives]     [Linux RAID]     [Linux SCSI]     [Linux ATA RAID]     [IDE]     [Linux Wireless]     [Linux Kernel]     [ATH6KL]     [Linux Bluetooth]     [Linux Netdev]     [Kernel Newbies]     [Security]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Device Mapper]

  Powered by Linux