On 3/29/22 3:40 AM, Yu Kuai wrote: > Currently, the splited bio is handled first, and then continue to split > the original bio. This patch tries to split the original bio thoroughly, > so that it can be known in advance how many tags will be needed. This makes the bio almost 10% bigger in size, which is NOT something that is just done casually and without strong reasoning. So please provide that, your commit message is completely missing justification for why this change is useful or necessary. A good commit always explains WHY the change needs to be made, yours is simply stating WHAT is being done. The latter can be gleaned from the code change anyway. -- Jens Axboe
