Re: [PATCH] scsi: sd: Jump to out_free_index if device_add{,_disk}() fail

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

To: "Fabio M. De Francesco" <fmdefrancesco@xxxxxxxxx>
Subject: Re: [PATCH] scsi: sd: Jump to out_free_index if device_add{,_disk}() fail
From: Dan Carpenter <dan.carpenter@xxxxxxxxxx>
Date: Tue, 29 Mar 2022 10:57:53 +0300
Cc: axboe@xxxxxxxxx, linux-block@xxxxxxxxxxxxxxx, linux-kernel@xxxxxxxxxxxxxxx, syzkaller-bugs@xxxxxxxxxxxxxxxx, "James E.J. Bottomley" <jejb@xxxxxxxxxxxxx>, "Martin K. Petersen" <martin.petersen@xxxxxxxxxx>, linux-scsi@xxxxxxxxxxxxxxx, syzbot+f08c77040fa163a75a46@xxxxxxxxxxxxxxxxxxxxxxxxx
In-reply-to: <20220329074744.GR12805@kadam>
References: <20220328084452.11479-1-fmdefrancesco@gmail.com> <20220328143853.GU3293@kadam> <2179817.iZASKD2KPV@leap> <20220329074744.GR12805@kadam>
User-agent: Mutt/1.9.4 (2018-02-28)

On Tue, Mar 29, 2022 at 10:47:45AM +0300, Dan Carpenter wrote:
> No, this patch is wrong.  That is supposed to be freed in scsi_disk_release()
> but apparently that's not getting called.  Is the ref counting off?
> 

Yeah.  The device_add() needs a matching device_del().

regards,
dan carpenter

Follow-Ups:
- Re: [PATCH] scsi: sd: Jump to out_free_index if device_add{,_disk}() fail
  - From: Fabio M. De Francesco

References:
- [PATCH] scsi: sd: Jump to out_free_index if device_add{,_disk}() fail
  - From: Fabio M. De Francesco
- Re: [PATCH] scsi: sd: Jump to out_free_index if device_add{,_disk}() fail
  - From: Dan Carpenter
- Re: [PATCH] scsi: sd: Jump to out_free_index if device_add{,_disk}() fail
  - From: Fabio M. De Francesco
- Re: [PATCH] scsi: sd: Jump to out_free_index if device_add{,_disk}() fail
  - From: Dan Carpenter

Prev by Date: Re: state of drbd in mainline
Next by Date: Re: [PATCH] scsi: sd: Jump to out_free_index if device_add{,_disk}() fail
Previous by thread: Re: [PATCH] scsi: sd: Jump to out_free_index if device_add{,_disk}() fail
Next by thread: Re: [PATCH] scsi: sd: Jump to out_free_index if device_add{,_disk}() fail
Index(es):
- Date
- Thread

[Index of Archives] [Linux RAID] [Linux SCSI] [Linux ATA RAID] [IDE] [Linux Wireless] [Linux Kernel] [ATH6KL] [Linux Bluetooth] [Linux Netdev] [Kernel Newbies] [Security] [Git] [Netfilter] [Bugtraq] [Yosemite News] [MIPS Linux] [ARM Linux] [Linux Security] [Device Mapper]