On Fri, Mar 25, 2022 at 8:18 AM Jens Axboe <axboe@xxxxxxxxx> wrote:
>
> This pull request adds support for 64-bit data integrity in the block
> layer and in NVMe.
I've pulled this, but people - please don't do silly things like this:
> Keith Busch (9):
> linux/kernel: introduce lower_48_bits function
There is *NO* excuse for adding this completely trivial and pointless
function to a core kernel header file.
It isn't generic enough to make sense. "48" just isn't a common enough number.
Maybe
It isn't *complex* enough to make sense.
It isn't even clarifying the code.
Honestly, the advantage of writing
seed = lower_48_bits(iter->seed);
over just writing it out the usual way, or using one of our existing
helpers like
seed = iter->seed & GENMASK_ULL(47,0);
is just not there.
And it damn well shouldn't be in some <linux/kernel.h> header file. If
you ABSOLUTELY need to have it, put it in some NVMe-specific header
file where it (maybe) belongs.
