On 3/4/22 08:03, Christoph Hellwig wrote:
+ /* + * This device is mostly just used to show a bunch of attributes in a + * weird place. In doubt don't add any new users, and most importantly + * don't use if for any actual refcounting. + */ + struct device disk_dev;
Isn't "weird place" subjective? How about mentioning the sysfs path explicitly (/sys/class/scsi_disk/H:C:I:L)? How about explaining why no new sysfs attributes should be added to that device instance?
Thanks, Bart.
