On 2/27/22 10:16 AM, Christoph Hellwig wrote: > On Thu, Feb 10, 2022 at 07:56:37PM +0800, Yu Kuai wrote: >> Throttled bios can't be issued after del_gendisk() is done, thus >> it's better to cancel them immediately rather than waiting for >> throttle is done. >> >> For example, if user thread is throttled with low bps while it's >> issuing large io, and the device is deleted. The user thread will >> wait for a long time for io to return. > > FYI, this crashed left rigt and center when running xfstests with > traces pointing to throtl_pending_timer_fn. Dropped for now. -- Jens Axboe