On 2/22/22 19:18, Jens Axboe wrote: > On 2/22/22 8:14 PM, Chaitanya Kulkarni wrote: >> On 2/22/22 18:58, Jens Axboe wrote: >>> On 2/22/22 7:49 PM, Chaitanya Kulkarni wrote: >>>> Hi, >>>> >>>> After today's pull on linux-block/for-next test QEMU is not able to >>>> boot, any information about how to solve this will be helpful as >>>> it is blocking blktest testing, here is dmsg :- >>>> >>>> [ 1.304698] ata1.00: Read log 0x00 page 0x00 failed, Emask 0x1 >>>> [ 1.305587] ata1.01: Read log 0x00 page 0x00 failed, Emask 0x1 >>>> [ 1.455959] systemd[1]: Cannot be run in a chroot() environment. >>>> [ 1.456743] systemd[1]: Freezing execution. >>> >>> What was the previous one you tried? What are the changes between the >>> two? >>> >> >> This is the one tried and can boot normally:- >> >> root@dev linux-block ((HEAD detached at 03546d43eb84)) # git log -1 >> commit 03546d43eb841d5fd66203822c2bb290a46464c9 (HEAD) >> Merge: a102cd383c4a 55143a783f07 >> Author: Jens Axboe <axboe@xxxxxxxxx> >> Date: Wed Feb 16 19:38:35 2022 -0700 >> >> Merge branch 'for-5.18/drivers' into for-next >> >> * for-5.18/drivers: >> null_blk: remove hardcoded alloc_cmd() parameter > > Can you bisect between those two? Not sure what this might be... > Something went wrong in my git bisect as it is pointing to following, will try again tomorrow :- root@dev linux-block ((no branch, bisect started on for-next)) # git bisect bad 4a330a241a41e4f2a9d752dea41be70803a66a94 is the first bad commit commit 4a330a241a41e4f2a9d752dea41be70803a66a94 Author: Chaitanya Kulkarni <kch@xxxxxxxxxx> Date: Tue Feb 22 07:28:51 2022 -0800 null_blk: remove hardcoded null_alloc_page() param Meanwhile I found Oops this with HEAD :- root@dev linux-block ((no branch, bisect started on for-next)) # git log -1 commit 2ff4ec783f4c635289384398d14b241f21bce269 (HEAD, origin/for-5.18/drivers) Author: Chaitanya Kulkarni <kch@xxxxxxxxxx> Date: Tue Feb 22 07:28:52 2022 -0800 null_blk: null_alloc_page() cleanup Remove goto labels and use direct returns as error unwinding code only needs to free t_page variable if we alloc_pages() call fails as having two labels for one kfree() can be avoided easily. Signed-off-by: Chaitanya Kulkarni <kch@xxxxxxxxxx> Reviewed-by: Christoph Hellwig <hch@xxxxxx> Link: https://lore.kernel.org/r/20220222152852.26043-3-kch@xxxxxxxxxx Signed-off-by: Jens Axboe <axboe@xxxxxxxxx> [ OK ] Mounted Kernel Configuration File System. [ 4.193905] BUG: kernel NULL pointer dereference, address: 0000000000000155 [ 4.194044] systemd[1]: Finished Apply Kernel Variables. [ 4.195596] #PF: supervisor read access in kernel mode [ 4.195599] #PF: error_code(0x0000) - not-present page [ 4.195600] PGD 0 P4D 0 [ 4.195603] Oops: 0000 [#1] PREEMPT SMP NOPTI [ 4.195606] CPU: 3 PID: 899 Comm: systemd-random- Not tainted 5.17.0-rc2blk+ #10 [ 4.195609] Hardware name: QEMU Standard PC (i440FX + PIIX, 1996), BIOS rel-1.14.0-0-g155821a1990b-prebuilt.qemu.org 04/01/2014 [ 4.195610] RIP: 0010:submit_bio_checks+0x17f/0x570 [ 4.195618] Code: ff 48 8b 45 48 48 85 c0 74 0f 48 63 15 6a 87 44 01 48 8b 84 d0 b8 00 00 00 44 0f b7 65 14 41 c0 ec 07 75 20 8b 55 10 83 e2 01 <80> bc 10 54 01 00 00 00 74 10 48 89 ef e8 cf 5f 02 00 84 c0 0f 85 [ 4.195620] RSP: 0018:ffffc90000ebfa98 EFLAGS: 00010202 [ 4.195622] RAX: 0000000000000000 RBX: 00000000061ff800 RCX: ffff88810458d140 [ 4.195624] RDX: 0000000000000001 RSI: ffff88810458f080 RDI: ffff8881049d7b00 [ 4.195625] RBP: ffff8881049d7b00 R08: 0000000000000000 R09: ffffc90000ebfb78 [ 4.195626] R10: 00000000000003a6 R11: 000000000130581e R12: 0000000000000800 [ 4.195628] R13: ffff88810458f080 R14: ffff888103001000 R15: ffff8881049d7b00 [ 4.195631] FS: 00007f66a5828b40(0000) GS:ffff888fff2c0000(0000) knlGS:0000000000000000 [ 4.195633] CS: 0010 DS: 0000 ES: 0000 CR0: 0000000080050033 [ 4.195634] CR2: 0000000000000155 CR3: 0000000177042000 CR4: 0000000000350ee0 [ 4.195638] Call Trace: [ 4.195652] <TASK> [ 4.195655] ? __filemap_fdatawait_range+0xa9/0xf0 [ 4.195660] ? __kmalloc_track_caller+0x210/0x310 [ 4.195664] __submit_bio+0x1c/0x140 [ 4.195667] submit_bio_noacct+0x257/0x2a0 [ 4.195670] ? bio_reset+0x16/0x60 [ 4.195673] write_all_supers+0x53c/0xa70 [ 4.231372] btrfs_sync_log+0x8df/0xbd0 [ 4.231379] ? do_wait_intr_irq+0xa0/0xa0 [ 4.232689] btrfs_sync_file+0x399/0x4e0 [ 4.233322] systemd[1]: Started Journal Service. [ 4.233416] __x64_sys_fsync+0x33/0x60 [ 4.234973] do_syscall_64+0x3b/0x90 [ 4.234978] entry_SYSCALL_64_after_hwframe+0x44/0xae [ 4.234981] RIP: 0033:0x7f66a649e347 [ 4.234985] Code: 64 89 01 48 83 c8 ff c3 66 2e 0f 1f 84 00 00 00 00 00 90 f3 0f 1e fa 64 8b 04 25 18 00 00 00 85 c0 75 10 b8 4a 00 00 00 0f 05 <48> 3d 00 f0 ff ff 77 41 c3 48 83 ec 18 89 7c 24 0c e8 e3 db f8 ff [ 4.243031] RSP: 002b:00007fffd98f23a8 EFLAGS: 00000246 ORIG_RAX: 000000000000004a [ 4.243035] RAX: ffffffffffffffda RBX: 00007f66a68cc855 RCX: 00007f66a649e347 [ 4.243036] RDX: 0000000000000052 RSI: 00007f66a68cc855 RDI: 0000000000000004 [ 4.243038] RBP: 0000000000000004 R08: 00007f66a6e85f60 R09: 00007f66a6569a60 [ 4.243039] R10: 0000000000000000 R11: 0000000000000246 R12: 0000000000000005 [ 4.243040] R13: 00007f66a6e85f60 R14: 0000000000000200 R15: 0000000000000001 [ 4.243044] </TASK> [ 4.250627] Modules linked in: zram ip_tables bochs drm_vram_helper drm_kms_helper drm_ttm_helper ttm drm nvme crct10dif_pclmul crc32_pclmul crc32c_intel virtio_net nvme_core ghash_clmulni_intel net_failover ata_generic failover serio_raw pata_acpi qemu_fw_cfg fuse Entering kdb (current=0xffff88810fbcd080, pid 899) on processor 3 Oops: (null) due to oops @ 0xffffffff816024af CPU: 3 PID: 899 Comm: systemd-random- Not tainted 5.17.0-rc2blk+ #10 Hardware name: QEMU Standard PC (i440FX + PIIX, 1996), BIOS rel-1.14.0-0-g155821a1990b-prebuilt.qemu.org 04/01/2014 RIP: 0010:submit_bio_checks+0x17f/0x570 Code: ff 48 8b 45 48 48 85 c0 74 0f 48 63 15 6a 87 44 01 48 8b 84 d0 b8 00 00 00 44 0f b7 65 14 41 c0 ec 07 75 20 8b 55 10 83 e2 01 <80> bc 10 54 01 00 00 00 74 10 48 89 ef e8 cf 5f 02 00 84 c0 0f 85 RSP: 0018:ffffc90000ebfa98 EFLAGS: 00010202 RAX: 0000000000000000 RBX: 00000000061ff800 RCX: ffff88810458d140 RDX: 0000000000000001 RSI: ffff88810458f080 RDI: ffff8881049d7b00 RBP: ffff8881049d7b00 R08: 0000000000000000 R09: ffffc90000ebfb78 R10: 00000000000003a6 R11: 000000000130581e R12: 0000000000000800 R13: ffff88810458f080 R14: ffff888103001000 R15: ffff8881049d7b00 FS: 00007f66a5828b40(0000) GS:ffff888fff2c0000(0000) knlGS:0000000000000000 CS: 0010 DS: 0000 ES: 0000 CR0: 0000000080050033 CR2: 0000000000000155 CR3: 0000000177042000 CR4: 0000000000350ee0 Call Trace: <TASK> ? __filemap_fdatawait_range+0xa9/0xf0 ? __kmalloc_track_caller+0x210/0x310 __submit_bio+0x1c/0x140 submit_bio_noacct+0x257/0x2a0 ? bio_reset+0x16/0x60 write_all_supers+0x53c/0xa70 btrfs_sync_log+0x8df/0xbd0 ? do_wait_intr_irq+0xa0/0xa0 btrfs_sync_file+0x399/0x4e0 __x64_sys_fsync+0x33/0x60 do_syscall_64+0x3b/0x90 entry_SYSCALL_64_after_hwframe+0x44/0xae RIP: 0033:0x7f66a649e347 Code: 64 89 01 48 83 c8 ff c3 66 2e 0f 1f 84 00 00 00 00 00 90 f3 0f 1e fa 64 8b 04 25 18 00 00 00 85 c0 75 10 b8 4a 00 00 00 0f 05 <48> 3d 00 f0 ff ff 77 41 c3 48 83 ec 18 89 7c 24 0c e8 e3 db f8 ff RSP: 002b:00007fffd98f23a8 EFLAGS: 00000246 ORIG_RAX: 000000000000004a RAX: ffffffffffffffda RBX: 00007f66a68cc855 RCX: 00007f66a649e347 RDX: 0000000000000052 RSI: 00007f66a68cc855 RDI: 0000000000000004 RBP: 0000000000000004 R08: 00007f66a6e85f60 R09: 00007f66a6569a60 R10: 0000000000000000 R11: 0000000000000246 R12: 0000000000000005 R13: 00007f66a6e85f60 R14: 0000000000000200 R15: 0000000000000001 </TASK> [3]kdb> bt Stack traceback for pid 899 0xffff88810fbcd080 899 1 1 3 R 0xffff88810fbcf440 *systemd-random- CPU: 3 PID: 899 Comm: systemd-random- Not tainted 5.17.0-rc2blk+ #10 Hardware name: QEMU Standard PC (i440FX + PIIX, 1996), BIOS rel-1.14.0-0-g155821a1990b-prebuilt.qemu.org 04/01/2014 Call Trace: <TASK> dump_stack_lvl+0x48/0x5e kdb_show_stack+0x75/0x80 kdb_bt1+0xb7/0x130 kdb_bt+0x343/0x3b0 kdb_parse+0x2b6/0x6f0 kdb_main_loop+0x47e/0x8f0 kdb_stub+0x224/0x400 kgdb_cpu_enter+0x330/0x5c0 kgdb_handle_exception+0xb6/0x100 __kgdb_notify+0x30/0x80 kgdb_notify+0x1f/0x40 notify_die+0x6f/0xb0 __die_body+0x7d/0x90 page_fault_oops+0xae/0x270 ? do_user_addr_fault+0x66/0x690 exc_page_fault+0x72/0x170 asm_exc_page_fault+0x1e/0x30 RIP: 0010:submit_bio_checks+0x17f/0x570 Code: ff 48 8b 45 48 48 85 c0 74 0f 48 63 15 6a 87 44 01 48 8b 84 d0 b8 00 00 00 44 0f b7 65 14 41 c0 ec 07 75 20 8b 55 10 83 e2 01 <80> bc 10 54 01 00 00 00 74 10 48 89 ef e8 cf 5f 02 00 84 c0 0f 85 RSP: 0018:ffffc90000ebfa98 EFLAGS: 00010202 RAX: 0000000000000000 RBX: 00000000061ff800 RCX: ffff88810458d140 RDX: 0000000000000001 RSI: ffff88810458f080 RDI: ffff8881049d7b00 RBP: ffff8881049d7b00 R08: 0000000000000000 R09: ffffc90000ebfb78 R10: 00000000000003a6 R11: 000000000130581e R12: 0000000000000800 R13: ffff88810458f080 R14: ffff888103001000 R15: ffff8881049d7b00 ? submit_bio_checks+0x79/0x570 ? __filemap_fdatawait_range+0xa9/0xf0 ? __kmalloc_track_caller+0x210/0x310 __submit_bio+0x1c/0x140 submit_bio_noacct+0x257/0x2a0 ? bio_reset+0x16/0x60 write_all_supers+0x53c/0xa70 btrfs_sync_log+0x8df/0xbd0 ? do_wait_intr_irq+0xa0/0xa0 btrfs_sync_file+0x399/0x4e0 __x64_sys_fsync+0x33/0x60 do_syscall_64+0x3b/0x90 entry_SYSCALL_64_after_hwframe+0x44/0xae RIP: 0033:0x7f66a649e347 Code: 64 89 01 48 83 c8 ff c3 66 2e 0f 1f 84 00 00 00 00 00 90 f3 0f 1e fa 64 8b 04 25 18 00 00 00 85 c0 75 10 b8 4a 00 00 00 0f 05 <48> 3d 00 f0 ff ff 77 41 c3 48 83 ec 18 89 7c 24 0c e8 e3 db f8 ff RSP: 002b:00007fffd98f23a8 EFLAGS: 00000246 ORIG_RAX: 000000000000004a RAX: ffffffffffffffda RBX: 00007f66a68cc855 RCX: 00007f66a649e347 RDX: 0000000000000052 RSI: 00007f66a68cc855 RDI: 0000000000000004 RBP: 0000000000000004 R08: 00007f66a6e85f60 R09: 00007f66a6569a60 R10: 0000000000000000 R11: 0000000000000246 R12: 0000000000000005 R13: 00007f66a6e85f60 R14: 0000000000000200 R15: 0000000000000001 </TASK> [3]kdb> -ck