On 2/9/22 10:51 PM, Christoph Hellwig wrote: > On Wed, Feb 09, 2022 at 01:00:26PM -0500, Martin K. Petersen wrote: >> >> Christoph, >> >>> Now that we are using REQ_OP_WRITE_ZEROES for all zeroing needs in the >>> kernel there is very little use left for REQ_OP_WRITE_SAME. We only >>> have two callers left, and both just export optional protocol features >>> to remote systems: DRBD and the target code. >> >> No particular objections from me. I had a half-baked series to do the >> same thing. >> >> One thing I would like is to either pull this series through SCSI or do >> the block pieces in a post merge branch because I'm about to post my >> discard/zeroing rework and that's going to clash with your changes. > > I'd be fine with taking this through the SCSI tree. Or we can wait > another merge window to make your life easier. Let's just use the SCSI tree - I didn't check if it throws any conflicts right now, so probably something to check upfront... If things pan out, you can add my Acked-by to the series. -- Jens Axboe