On 2022/2/16 5:23 上午, Bart Van Assche wrote: > On 2/15/22 04:37, Wang Jianchao (Kuaishou) wrote: >> @@ -337,6 +338,7 @@ void blk_cleanup_queue(struct request_queue *q) >> * it is safe to free requests now. >> */ >> mutex_lock(&q->sysfs_lock); >> + rq_qos_exit(q); >> if (q->elevator) >> blk_mq_sched_free_rqs(q); >> mutex_unlock(&q->sysfs_lock); > > I think this change should be a separate patch with tag "Fixes: 8e141f9eb803 ("block: drain file system I/O on del_gendisk")". See also https://lore.kernel.org/linux-block/b64942a1-0f7e-9e9c-0fd4-c35647035eaf@xxxxxxx/ > Yes, I will do it in next version Thanks Jianchao