On Mon, Feb 14, 2022 at 11:57:14PM -0800, Christoph Hellwig wrote:
> On Tue, Feb 15, 2022 at 11:30:46AM +0800, Ming Lei wrote:
> > The bio has been checked already before throttling, so no need to check
> > it again before dispatching it from throttle queue.
> >
> > Add one local helper of submit_bio_noacct_nocheck() for this purpose.
>
> s/one/a/. Also I'm not sure I'd call it "local" given that it is used in
> a different file.
>
> > +void submit_bio_noacct_nocheck(struct bio *bio)
> > +{
> > + __submit_bio_noacct_nocheck(bio);
> > +}
>
> No need for a wrapper here.
The wrapper is for avoiding to add extra function call code in fast
path since submit_bio_noacct_nocheck is global and can't be inlined.
Thanks,
Ming
