> + if (!blk_throtl_bio(bio)) {
> + blk_cgroup_bio_start(bio);
> + blkcg_bio_issue_init(bio);
> +
> + if (!bio_flagged(bio, BIO_TRACE_COMPLETION)) {
> + trace_block_bio_queue(bio);
> + /* Now that enqueuing has been traced, we need to
> + * trace completion as well.
> + */
> + bio_set_flag(bio, BIO_TRACE_COMPLETION);
> + }
> +
> + __submit_bio_noacct_nocheck(bio);
I much prefered the early return in the old code as it clearly
document the flow.
Otherwise looks good:
Reviewed-by: Christoph Hellwig <hch@xxxxxx>
