Re: [PATCH 0/4] blk-lib: cleanup bdev_get_queue()

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 2/14/22 3:19 AM, Chaitanya Kulkarni wrote:
> On 2/14/22 2:08 AM, Chaitanya Kulkarni wrote:
>> Hi,
>>
>> Based on the comment in the include/linux/blkdev.h:bdev_get_queue()
>> the return value of the function will never be NULL. This patch series
>> removes those checks present in the blk-lib.c, also removes the not
>> needed local variable pointer to request_queue from the write_zeroes
>> helpers.
>>
>> Below is the test log for  discard (__blkdev_issue_disacrd()) and
>> write-zeroes (__blkdev_issue_write_zeroes/__blkdev_issue_zero_pages()).
>>
>> -ck
>>
> 
> This clashes with Christoph's write same cleanup. I'll resend this
> once that is in the linux-block tree, meanwhile any comments on
> discard, write-zeroes and zero-pages patches are welcome.

Please just collapse those patches into 1. Right now it's 4 patches
with identical titles, that's very confusing.

-- 
Jens Axboe




[Index of Archives]     [Linux RAID]     [Linux SCSI]     [Linux ATA RAID]     [IDE]     [Linux Wireless]     [Linux Kernel]     [ATH6KL]     [Linux Bluetooth]     [Linux Netdev]     [Kernel Newbies]     [Security]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Device Mapper]

  Powered by Linux