Re: [PATCH v1 1/1] block: Add handling for zone append command in blk_complete_request

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 11/02/2022 17:17, Luis Chamberlain wrote:
> On Fri, Feb 11, 2022 at 10:02:26AM +0000, Johannes Thumshirn wrote:
>> On 11/02/2022 10:42, Pankaj Raghav wrote:
>>> Zone append command needs special handling to update the bi_sector
>>> field in the bio struct with the actual position of the data in the
>>> device. It is stored in __sector field of the request struct.
>>>
>>> Fixes: 5581a5ddfe8d ("block: add completion handler for fast path")
>>> Signed-off-by: Pankaj Raghav <p.raghav@xxxxxxxxxxx>
>>
>> I would've preferred if you had put the trace and steps to reproduce 
>> in the changelog instead of the cover letter but, maybe Jens can update
>> it when he applies the patch.
> 
> That would be wonderful. And a new fstests :)
> 
> I'm surprised no one caught this earlier... does this mean... no fstests
> yet covers this? If a test does... then does that mean...
> 
>   No one is testing zone btrfs... since... around December
>   (5581a5ddfe8d) or January (merge commit to Linus)?

Ahm no. Please be sure we do test zoned btrfs. But yes, I'm at the
moment not testing on ZNS drives, so I haven't caught the bug earlier.





[Index of Archives]     [Linux RAID]     [Linux SCSI]     [Linux ATA RAID]     [IDE]     [Linux Wireless]     [Linux Kernel]     [ATH6KL]     [Linux Bluetooth]     [Linux Netdev]     [Kernel Newbies]     [Security]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Device Mapper]

  Powered by Linux