On Wed, Feb 09, 2022 at 11:16:13AM +0100, Jinpu Wang wrote: > Hi Christoph, > > > On Wed, Feb 9, 2022 at 9:28 AM Christoph Hellwig <hch@xxxxxx> wrote: > > > > REQ_OP_WRITE_SAME was only ever submitted by the legacy Linux zeroing > > code, which has switched to use REQ_OP_WRITE_ZEROES long before rnbd was > > even merged. > > Do you think if it makes sense to instead of removing > REQ_OP_WRITE_SAME, simply convert it to REQ_OP_WRITE_ZEROES? Well, they have different semantics, so you can't just "convert" it. But it might make sense to add REQ_OP_WRITE_ZEROES.
