Re: [PATCH 2/2] nvme: add vectored-io support for user passthru

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

To: Kanchan Joshi <joshiiitr@xxxxxxxxx>, Christoph Hellwig <hch@xxxxxx>
Subject: Re: [PATCH 2/2] nvme: add vectored-io support for user passthru
From: Chaitanya Kulkarni <chaitanyak@xxxxxxxxxx>
Date: Fri, 28 Jan 2022 09:08:21 +0000
Accept-language: en-US
Cc: Kanchan Joshi <joshi.k@xxxxxxxxxxx>, Keith Busch <kbusch@xxxxxxxxxx>, Jens Axboe <axboe@xxxxxxxxx>, "linux-nvme@xxxxxxxxxxxxxxxxxxx" <linux-nvme@xxxxxxxxxxxxxxxxxxx>, "linux-block@xxxxxxxxxxxxxxx" <linux-block@xxxxxxxxxxxxxxx>
In-reply-to: <CA+1E3r+tZH4AtnHduTTZenbJTzn1pC9HuDcYNaZUVX4+umyk5w@mail.gmail.com>
References: <20220127082536.7243-1-joshi.k@samsung.com> <CGME20220127083035epcas5p3e3760849513fb7939757f4e6678405a0@epcas5p3.samsung.com> <20220127082536.7243-3-joshi.k@samsung.com> <20220127092921.GB14431@lst.de> <CA+1E3r+tZH4AtnHduTTZenbJTzn1pC9HuDcYNaZUVX4+umyk5w@mail.gmail.com>
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.11.0

Flags overloading for a completely different ABI is a bad idea.
>> Please add a separate ioctl instead.
> 
> Hope "NVME_IOCTL_IO64_VEC_CMD" sounds fine for the new one?
> 

sounds reasonable to me..

> --
> Kanchan
>

References:
- [PATCH 0/2] nvme-passthru with vectored-io
  - From: Kanchan Joshi
- [PATCH 2/2] nvme: add vectored-io support for user passthru
  - From: Kanchan Joshi
- Re: [PATCH 2/2] nvme: add vectored-io support for user passthru
  - From: Christoph Hellwig
- Re: [PATCH 2/2] nvme: add vectored-io support for user passthru
  - From: Kanchan Joshi

Prev by Date: Re: [PATCH 1/2] block: introduce and export blk_rq_map_user_vec
Next by Date: Re: [PATCH] block: fix boolreturn.cocci warning
Previous by thread: Re: [PATCH 2/2] nvme: add vectored-io support for user passthru
Next by thread: [RFC] blk-mq: complete request locallly if not in interrupt context
Index(es):
- Date
- Thread

[Index of Archives] [Linux RAID] [Linux SCSI] [Linux ATA RAID] [IDE] [Linux Wireless] [Linux Kernel] [ATH6KL] [Linux Bluetooth] [Linux Netdev] [Kernel Newbies] [Security] [Git] [Netfilter] [Bugtraq] [Yosemite News] [MIPS Linux] [ARM Linux] [Linux Security] [Device Mapper]