On Tue, Jan 25, 2022 at 05:27:36PM +0800, Ming Lei wrote: > > But it is configure code path, even though vfs_statfs() fails, > loop_config_discard() still need to keep discard setting consistent. > > Setting granularity as PAGE_SIZE is just for making discard granularity > matched with max_discard_sectors. Or you have better/simpler handling? I'd fail the entire configuration preferably. Or at least not support discard at all.