On Tue, Jan 25, 2022 at 07:27:37AM +0800, Ming Lei wrote: > > Please explain what "queue data for disk" is, and why this helper is > > Here it means elevator, blk-cgroup and rq qos, all actually serve FS > IOs, maybe it should be changed to FS IOs. > > > useful. Right now it seems to just move a few things around without a > > rationale or explanation of why it is safe. > > This patch just moves two function calls into the helper, and there > doesn't have functional change, so no need rationale and explanation. Yes, it it does. If you move calls into a "helper" that has a single caller and a weird name it better have a good explanation, because the move does not look useful at all.
