> @@ -1308,6 +1316,10 @@ struct gendisk *__alloc_disk_node(struct request_queue *q, int node_id, > if (xa_insert(&disk->part_tbl, 0, disk->part0, GFP_KERNEL)) > goto out_destroy_part_tbl; > > + /* todo: move blkcg into gendisk */ > + if (blkcg_init_queue(q)) > + goto out_erase_part0; > + I don't think having this todo comment here is helpful (even if I agree with the move and actually half old preliminary patches for that). With this comment dropped: Reviewed-by: Christoph Hellwig <hch@xxxxxx>
