Re: [PATCH 1/3] block: move freeing disk into queue's release handler

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Tue, Jan 18, 2022 at 11:47:33PM +0800, Ming Lei wrote:
> On Tue, Jan 18, 2022 at 09:22:59AM +0100, Christoph Hellwig wrote:
> > How does this work for SCSI where we can detach the disk from the
> > request queue, reattach it and then maybe later free them both?
> 
> Commit 8e141f9eb803 ("block: drain file system I/O on del_gendisk") has
> marked queue as dying, so how can the above case work given no any code
> clears the queue's dying flag?

oops, my fault, blk_queue_start_drain() actually doesn't set
QUEUE_FLAG_DYING, so the rettach case works with commit 8e141f9eb803.


Thanks,
Ming




[Index of Archives]     [Linux RAID]     [Linux SCSI]     [Linux ATA RAID]     [IDE]     [Linux Wireless]     [Linux Kernel]     [ATH6KL]     [Linux Bluetooth]     [Linux Netdev]     [Kernel Newbies]     [Security]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Device Mapper]

  Powered by Linux