On Tue, Jan 11, 2022 at 08:34:01PM +0800, Ming Lei wrote:
> srcu structure has to be cleanup via cleanup_srcu_struct(), so fix it.
>
> Reported-by: syzbot+4f789823c1abc5accf13@xxxxxxxxxxxxxxxxxxxxxxxxx
> Fixes: 704b914f15fb ("blk-mq: move srcu from blk_mq_hw_ctx to request_queue")
> Signed-off-by: Ming Lei <ming.lei@xxxxxxxxxx>
> ---
> block/blk-sysfs.c | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/block/blk-sysfs.c b/block/blk-sysfs.c
> index e20eadfcf5c8..8d8549f71311 100644
> --- a/block/blk-sysfs.c
> +++ b/block/blk-sysfs.c
> @@ -811,6 +811,9 @@ static void blk_release_queue(struct kobject *kobj)
>
> bioset_exit(&q->bio_split);
>
> + if (blk_queue_has_srcu(q))
> + cleanup_srcu_struct(q->srcu);
> +
> ida_simple_remove(&blk_queue_ida, q->id);
> call_rcu(&q->rcu_head, blk_free_queue_rcu);
Hello Jens,
Can we make it into mainline to fix the recent syzbot report?
Thanks,
Ming
