On Wed, Dec 29, 2021 at 06:39:02PM +0100, Christoph Hellwig wrote: > (except for the fact that it, just like the other rq_list helpers > really should go into blk-mq.h, where all request related bits moved > early in this cycle) Agreed, I just put it here because it's where the other macros live. But 'struct request' doesn't exist in this header, so it does seem out of place. For v3, I'll add a preceding patch to move them all to blk-mq.h.