On Dec 23, 2021 / 17:55, Jens Axboe wrote: > On 12/23/21 5:52 PM, Shinichiro Kawasaki wrote: > > On Dec 03, 2021 / 21:09, Ming Lei wrote: > >> There isn't any reason to not allow zero poll queues from user > >> viewpoint. > >> > >> Also sometimes we need to compare io poll between poll mode and irq > >> mode, so not allowing poll queues is bad. > >> > >> Fixes: 15dfc662ef31 ("null_blk: Fix handling of submit_queues and poll_queues attributes") > >> Cc: Shin'ichiro Kawasaki <shinichiro.kawasaki@xxxxxxx> > >> Signed-off-by: Ming Lei <ming.lei@xxxxxxxxxx> > >> --- > >> V2: > >> - fix divide zero fault as reported by Shin'ichiro > > > > Jens, Ming, > > > > I find the V1 was applied to the for/5.17-drivers branch, and the additional fix > > in the V2 does not look applied to the branch. Do we need another small patch to > > cover the delta between V1 and V2? > > Yes, please send an incremental, thanks. Thanks, and Ming already provided the small patch (So quick!). I've confirmed that the patch avoids the issue. Merge to for/5.17-drivers will be appreciated. -- Best Regards, Shin'ichiro Kawasaki