Re: [PATCH] blk-mq: check quiesce state before queue_rqs

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Keith,

I love your patch! Perhaps something to improve:

[auto build test WARNING on axboe-block/for-next]
[also build test WARNING on next-20211220]
[cannot apply to v5.16-rc6]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]

url:    https://github.com/0day-ci/linux/commits/Keith-Busch/blk-mq-check-quiesce-state-before-queue_rqs/20211221-045504
base:   https://git.kernel.org/pub/scm/linux/kernel/git/axboe/linux-block.git for-next
config: um-i386_defconfig (https://download.01.org/0day-ci/archive/20211221/202112210618.hCiNGmq9-lkp@xxxxxxxxx/config)
compiler: gcc-9 (Debian 9.3.0-22) 9.3.0
reproduce (this is a W=1 build):
        # https://github.com/0day-ci/linux/commit/8004ce63b95d4be66e4ad8655a05ee21a9a148d8
        git remote add linux-review https://github.com/0day-ci/linux
        git fetch --no-tags linux-review Keith-Busch/blk-mq-check-quiesce-state-before-queue_rqs/20211221-045504
        git checkout 8004ce63b95d4be66e4ad8655a05ee21a9a148d8
        # save the config file to linux build tree
        mkdir build_dir
        make W=1 O=build_dir ARCH=um SUBARCH=i386 SHELL=/bin/bash

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@xxxxxxxxx>

All warnings (new ones prefixed by >>):

>> block/blk-mq.c:2552:6: warning: no previous prototype for '__blk_mq_flush_plug_list' [-Wmissing-prototypes]
    2552 | void __blk_mq_flush_plug_list(struct request_queue *q, struct blk_plug *plug)
         |      ^~~~~~~~~~~~~~~~~~~~~~~~


vim +/__blk_mq_flush_plug_list +2552 block/blk-mq.c

  2551	
> 2552	void __blk_mq_flush_plug_list(struct request_queue *q, struct blk_plug *plug)
  2553	{
  2554		if (blk_queue_quiesced(q))
  2555			return;
  2556		q->mq_ops->queue_rqs(&plug->mq_list);
  2557	}
  2558	

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@xxxxxxxxxxxx



[Index of Archives]     [Linux RAID]     [Linux SCSI]     [Linux ATA RAID]     [IDE]     [Linux Wireless]     [Linux Kernel]     [ATH6KL]     [Linux Bluetooth]     [Linux Netdev]     [Kernel Newbies]     [Security]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Device Mapper]

  Powered by Linux