On Thu, Dec 16, 2021 at 05:18:06PM +0100, Christoph Hellwig wrote: > > out_disk_release_events: > > - disk_release_events(disk); > > + /* disk_release() will call disk_release_events(). */ > > out_free_ext_minor: > > if (disk->major == BLOCK_EXT_MAJOR) > > blk_free_ext_minor(disk->first_minor); > > .. actually while you're at it - blk_free_ext_minor is also done > by bdev_free_inode called from disk_release. > > So we can just remove the out_disk_release_events and out_free_ext_minor > labels entirely. ... of course we can't. But we should return after the device_del instead of falling through to the other resource cleanups.