On 12/12/21 10:05 AM, Coly Li wrote: > Hi Jens, > > This is the v12 effort the enabling NVDIMM for bcache journal, the code > is under testing for months and quite stable now. Please consider to > take them for Linux v5.17 merge window. As I've mentioned before, this really needs some thorough review from people not associated with the project. I spent a bit of time on the first section of the patches, and it doesn't look ready to me. Do you have any tests for this new code? Any that exercise the error paths? -- Jens Axboe