On 12/6/21 12:38 AM, Christoph Hellwig wrote: > As mentioned last time I really don't like the proliferation of > tiny helpers with just two callers. See my patch I responded with > for my alternative. I tend to agree with you, but for this particular case I really don't think it's better to not have the helper. I did try that version too, but you end up with several sites duplicating it. So while I agree in general, I don't think this one applies. -- Jens Axboe
