Hi Dan, This is the v4 effort to improve badblocks code APIs to handle multiple ranges in bad block table. Comparing to v3 series, the v4 series modification is for code review comments from Geliang Tang, - Declare local variables in reverse Xmas tree order. - Drop orig_start and orig_len from struct badblocks_context. - Fix typos in code comments. - in badblocks_set() avoid one unnecessary loop by setting variable hint by prev (was prev - 1 in v3 series). There is NO in-memory or on-disk format change in the whole series, all existing API and data structures are consistent. This series just only improve the code algorithm to handle more corner cases, the interfaces are same and consistency to all existing callers (md raid and nvdimm drivers). The original motivation of the change is from the requirement from our customer, that current badblocks routines don't handle multiple ranges. For example if the bad block setting range covers multiple ranges from bad block table, only the first two bad block ranges merged and rested ranges are intact. The expected behavior should be all the covered ranges to be handled. All the patches are tested by modified user space code and the code logic works as expected. The modified user space testing code is provided in last patch. The testing code is an example how the improved code is tested. The whole change is divided into 6 patches to make the code review more clear and easier. If people prefer, I'd like to post a single large patch finally after the code review accomplished. Please review the code and response. Thank you all in advance. Coly Li Cc: Dan Williams <dan.j.williams@xxxxxxxxx> Cc: Geliang Tang <geliang.tang@xxxxxxxx> Cc: Hannes Reinecke <hare@xxxxxxx> Cc: Jens Axboe <axboe@xxxxxxxxx> Cc: NeilBrown <neilb@xxxxxxx> Cc: Richard Fan <richard.fan@xxxxxxxx> Cc: Vishal L Verma <vishal.l.verma@xxxxxxxxx> --- Coly Li (6): badblocks: add more helper structure and routines in badblocks.h badblocks: add helper routines for badblock ranges handling badblocks: improvement badblocks_set() for multiple ranges handling badblocks: improve badblocks_clear() for multiple ranges handling badblocks: improve badblocks_check() for multiple ranges handling badblocks: switch to the improved badblock handling code Coly Li (1): test: user space code to test badblocks APIs block/badblocks.c | 1602 ++++++++++++++++++++++++++++++------- include/linux/badblocks.h | 30 + 2 files changed, 1337 insertions(+), 295 deletions(-) -- 2.31.1
