On 2021/11/19 8:57, Tadeusz Struk wrote: > From: Xie Yongji <xieyongji@xxxxxxxxxxxxx> > > From: Xie Yongji <xieyongji@xxxxxxxxxxxxx> > > There are some duplicated codes to validate the block > size in block drivers. This limitation actually comes > from block layer, so this patch tries to add a new block > layer helper for that. > > Signed-off-by: Xie Yongji <xieyongji@xxxxxxxxxxxxx> > Link: https://lore.kernel.org/r/20211026144015.188-2-xieyongji@xxxxxxxxxxxxx > Signed-off-by: Jens Axboe <axboe@xxxxxxxxx> > Signed-off-by: Tadeusz Struk <tadeusz.struk@xxxxxxxxxx> > --- > include/linux/blkdev.h | 8 ++++++++ > 1 file changed, 8 insertions(+) > > diff --git a/include/linux/blkdev.h b/include/linux/blkdev.h > index 683aee365420..5b03795ae33b 100644 > --- a/include/linux/blkdev.h > +++ b/include/linux/blkdev.h > @@ -54,6 +54,14 @@ struct blk_keyslot_manager; > */ > #define BLKCG_MAX_POLS 6 > > +static inline int blk_validate_block_size(unsigned int bsize) > +{ > + if (bsize < 512 || bsize > PAGE_SIZE || !is_power_of_2(bsize)) > + return -EINVAL; > + > + return 0; > +} > + > typedef void (rq_end_io_fn)(struct request *, blk_status_t); > > /* > But where is this used in 5.15 ? I do not see any callers for this. So why backport it ? -- Damien Le Moal Western Digital Research