On Wed, Nov 17, 2021 at 06:39:55AM +0000, cgel.zte@xxxxxxxxx wrote:
From: Ye Guojin <ye.guojin@xxxxxxxxxx>
This was found by coccicheck:
./drivers/block/virtio_blk.c, 334, 14-17, WARNING Unsigned expression
compared with zero num < 0
We should add the Fixes tag:
Fixes: 02746e26c39e ("virtio-blk: avoid preallocating big SGL for data")
Reported-by: Zeal Robot <zealci@xxxxxxxxxx>
Signed-off-by: Ye Guojin <ye.guojin@xxxxxxxxxx>
---
drivers/block/virtio_blk.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/block/virtio_blk.c b/drivers/block/virtio_blk.c
index 97bf051a50ce..eed1666eff31 100644
--- a/drivers/block/virtio_blk.c
+++ b/drivers/block/virtio_blk.c
@@ -316,7 +316,7 @@ static blk_status_t virtio_queue_rq(struct
blk_mq_hw_ctx *hctx,
struct request *req = bd->rq;
struct virtblk_req *vbr = blk_mq_rq_to_pdu(req);
unsigned long flags;
- unsigned int num;
+ int num;
int qid = hctx->queue_num;
bool notify = false;
blk_status_t status;
--
2.25.1
The patch LGTM.
With the Fixes tag added:
Reviewed-by: Stefano Garzarella <sgarzare@xxxxxxxxxx>
