Re: [PATCH 4/5] block: move queue enter logic into blk_mq_submit_bio()

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

To: Geert Uytterhoeven <geert@xxxxxxxxxxxxxx>
Subject: Re: [PATCH 4/5] block: move queue enter logic into blk_mq_submit_bio()
From: "Martin K. Petersen" <martin.petersen@xxxxxxxxxx>
Date: Thu, 11 Nov 2021 10:36:07 -0500
Cc: "Martin K. Petersen" <martin.petersen@xxxxxxxxxx>, Jens Axboe <axboe@xxxxxxxxx>, Christoph Hellwig <hch@xxxxxxxxxxxxx>, linux-block@xxxxxxxxxxxxxxx, linux-m68k <linux-m68k@xxxxxxxxxxxxxxx>, Linux Kernel Mailing List <linux-kernel@xxxxxxxxxxxxxxx>
In-reply-to: <CAMuHMdVdwwT5yQPpQ5Frr-Un5OMk9LX3sF_zocOejrouSjaO-w@mail.gmail.com> (Geert Uytterhoeven's message of "Thu, 11 Nov 2021 15:48:37 +0100")
Organization: Oracle Corporation
References: <20211104182201.83906-1-axboe@kernel.dk> <20211104182201.83906-5-axboe@kernel.dk> <YYQoLzMn7+s9hxpX@infradead.org> <2865c289-7014-2250-0f5b-a9ed8770d0ec@kernel.dk> <YYQo4ougXZvgv11X@infradead.org> <8c6163f4-0c0f-5254-5f79-9074f5a73cfe@kernel.dk> <461c4758-2675-1d11-ac8a-6f25ef01d781@kernel.dk> <YYQr3jl3avsuOUAJ@infradead.org> <3d29a5ce-aace-6198-3ea9-e6f603e74aa1@kernel.dk> <YYQuyt2/y1MgzRi0@infradead.org> <87ee0091-9c2f-50e8-c8f2-dcebebb9de48@kernel.dk> <alpine.DEB.2.22.394.2111111350150.2780761@ramsan.of.borg> <yq1sfw2g7xr.fsf@ca-mkp.ca.oracle.com> <CAMuHMdVdwwT5yQPpQ5Frr-Un5OMk9LX3sF_zocOejrouSjaO-w@mail.gmail.com>

Geert,

>> > sd 0:0:0:0: [sda] tag#0 CDB: Write(10) 2a 08 00 00 00 01 00 00 08 00
                                               ^^
                                               FUA

> sd 0:0:0:0: [sda] Write cache: disabled, read cache: enabled, doesn't
> support DPO or FUA

The device is correct in rejecting the command, then. But I'm not sure
how the commit in question would cause us to inadvertently set that
flag...

-- 
Martin K. Petersen	Oracle Linux Engineering

References:
- [PATCHSET v3 0/5] Alloc batch fixes
  - From: Jens Axboe
- [PATCH 4/5] block: move queue enter logic into blk_mq_submit_bio()
  - From: Jens Axboe
- Re: [PATCH 4/5] block: move queue enter logic into blk_mq_submit_bio()
  - From: Christoph Hellwig
- Re: [PATCH 4/5] block: move queue enter logic into blk_mq_submit_bio()
  - From: Jens Axboe
- Re: [PATCH 4/5] block: move queue enter logic into blk_mq_submit_bio()
  - From: Christoph Hellwig
- Re: [PATCH 4/5] block: move queue enter logic into blk_mq_submit_bio()
  - From: Jens Axboe
- Re: [PATCH 4/5] block: move queue enter logic into blk_mq_submit_bio()
  - From: Jens Axboe
- Re: [PATCH 4/5] block: move queue enter logic into blk_mq_submit_bio()
  - From: Christoph Hellwig
- Re: [PATCH 4/5] block: move queue enter logic into blk_mq_submit_bio()
  - From: Jens Axboe
- Re: [PATCH 4/5] block: move queue enter logic into blk_mq_submit_bio()
  - From: Christoph Hellwig
- Re: [PATCH 4/5] block: move queue enter logic into blk_mq_submit_bio()
  - From: Jens Axboe
- Re: [PATCH 4/5] block: move queue enter logic into blk_mq_submit_bio()
  - From: Geert Uytterhoeven
- Re: [PATCH 4/5] block: move queue enter logic into blk_mq_submit_bio()
  - From: Martin K. Petersen
- Re: [PATCH 4/5] block: move queue enter logic into blk_mq_submit_bio()
  - From: Geert Uytterhoeven

Prev by Date: Re: uring regression - lost write request
Next by Date: Re: uring regression - lost write request
Previous by thread: Re: [PATCH 4/5] block: move queue enter logic into blk_mq_submit_bio()
Next by thread: Re: [PATCH 4/5] block: move queue enter logic into blk_mq_submit_bio()
Index(es):
- Date
- Thread

[Index of Archives] [Linux RAID] [Linux SCSI] [Linux ATA RAID] [IDE] [Linux Wireless] [Linux Kernel] [ATH6KL] [Linux Bluetooth] [Linux Netdev] [Kernel Newbies] [Security] [Git] [Netfilter] [Bugtraq] [Yosemite News] [MIPS Linux] [ARM Linux] [Linux Security] [Device Mapper]