Re: [PATCH 4/4] nvme: wait until quiesce is done

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

To: Ming Lei <ming.lei@xxxxxxxxxx>
Subject: Re: [PATCH 4/4] nvme: wait until quiesce is done
From: Keith Busch <kbusch@xxxxxxxxxx>
Date: Mon, 8 Nov 2021 08:45:50 -0800
Cc: Jens Axboe <axboe@xxxxxxxxx>, Yi Zhang <yi.zhang@xxxxxxxxxx>, linux-block@xxxxxxxxxxxxxxx, linux-nvme@xxxxxxxxxxxxxxxxxxx, "Martin K . Petersen" <martin.petersen@xxxxxxxxxx>, linux-scsi@xxxxxxxxxxxxxxx, James Bottomley <James.Bottomley@xxxxxxxxxxxxxxxxxxxxx>
In-reply-to: <20211103034305.3691555-5-ming.lei@redhat.com>
References: <20211103034305.3691555-1-ming.lei@redhat.com> <20211103034305.3691555-5-ming.lei@redhat.com>

On Wed, Nov 03, 2021 at 11:43:05AM +0800, Ming Lei wrote:
> NVMe uses one atomic flag to check if quiesce is needed. If quiesce is
> started, the helper returns immediately. This way is wrong, since we
> have to wait until quiesce is done.

Looks good to me.

Reviewed-by: Keith Busch <kbusch@xxxxxxxxxx>

References:
- [PATCH 0/4] block: fix concurrent quiesce
  - From: Ming Lei
- [PATCH 4/4] nvme: wait until quiesce is done
  - From: Ming Lei

Prev by Date: Re: [PATCH 3/4] scsi: make sure that request queue queiesce and unquiesce balanced
Next by Date: Re: general protection fault in del_gendisk
Previous by thread: [PATCH 4/4] nvme: wait until quiesce is done
Next by thread: Re: [PATCH 4/4] nvme: wait until quiesce is done
Index(es):
- Date
- Thread

[Index of Archives] [Linux RAID] [Linux SCSI] [Linux ATA RAID] [IDE] [Linux Wireless] [Linux Kernel] [ATH6KL] [Linux Bluetooth] [Linux Netdev] [Kernel Newbies] [Security] [Git] [Netfilter] [Bugtraq] [Yosemite News] [MIPS Linux] [ARM Linux] [Linux Security] [Device Mapper]

Powered by Linux