On 11/5/21 3:43 AM, Paolo Valente wrote:
>
>
>> Il giorno 4 nov 2021, alle ore 15:41, Jens Axboe <axboe@xxxxxxxxx> ha scritto:
>>
>> On 11/4/21 8:04 AM, Holger Hoffstätte wrote:
>>>
>>> Hi Jens,
>>>
>>> a simple no-code request:
>>>
>>> Commit d29bd41428cf ("block, bfq: reset last_bfqq_created on group change")
>>> fixed a UAF in bfq, which was previously worked-around by ebc69e897e17
>>> ("Revert "block, bfq: honor already-setup queue merges"").
>>>
>>> However since then the original commit 2d52c58b9c9b was never restored.
>>>
>>> Reinstating 2d52c58b9c9b has so far not resulted in any problems for me,
>>> and I think it would be nice to bring it back in early just to get
>>> feedback as early as possible in this cycle.
>>
>> Adding Paolo.
>>
>
> Yep, now that we have the fix, we should restore that commit.
Please send a patch that does that then, with the rationale included
in the commit message on why it's now safe to do so.
--
Jens Axboe
