On 11/4/21 12:34 PM, Christoph Hellwig wrote: > On Thu, Nov 04, 2021 at 12:21:57PM -0600, Jens Axboe wrote: >> Requests that were stored in the cache deliberately didn't hold an enter >> reference to the queue, instead we grabbed one every time we pulled a >> request out of there. That made for awkward logic on freeing the remainder >> of the cached list, if needed, where we had to artificially raise the >> queue usage count before each free. >> >> Grab references up front for cached plug requests. That's safer, and also >> more efficient. > > I think it would be useful to add zour explanation why the cached > requests should be flushed at schedule time now here. > > Otherwise this looks good: > > Reviewed-by: Christoph Hellwig <hch@xxxxxx> Thanks, I'll add a comment when amending with your reviewed-by. -- Jens Axboe
