On Mon, Nov 01, 2021 at 01:42:16PM -0600, Jens Axboe wrote:
> A previous commit fixed up the condition for doing direct issue, but that
> left the 'from_schedule' argument dead inside the branch. Replace it with
> 'false'.
>
> Fixes: ff1552232b36 ("blk-mq: don't issue request directly in case that current is to be blocked")
> Signed-off-by: Jens Axboe <axboe@xxxxxxxxx>
>
> ---
>
> diff --git a/block/blk-mq.c b/block/blk-mq.c
> index 4787d5b74aa3..8aed6cea3a34 100644
> --- a/block/blk-mq.c
> +++ b/block/blk-mq.c
> @@ -2227,7 +2227,7 @@ void blk_mq_flush_plug_list(struct blk_plug *plug, bool from_schedule)
> plug->rq_count = 0;
>
> if (!plug->multiple_queues && !plug->has_elevator && !from_schedule) {
> - blk_mq_plug_issue_direct(plug, from_schedule);
> + blk_mq_plug_issue_direct(plug, false);
> if (rq_list_empty(plug->mq_list))
> return;
Reviewed-by: Ming Lei <ming.lei@xxxxxxxxxx>
--
Ming
