On Wed, Oct 20, 2021 at 04:41:19PM +0200, Christoph Hellwig wrote:
> Consolidate the various helpers into a single blk_flush_plug helper that
> takes a plk_plug and the from_scheduler bool and switch all callsites to
> call it directly. Checks that the plug is non-NULL must be performed by
> the caller, something that most already do anyway.
>
> Signed-off-by: Christoph Hellwig <hch@xxxxxx>
This patch as commit 008f75a20e70 ("block: cleanup the flush plug
helpers") in -next causes the following errors with CONFIG_BLOCK=n
(tinyconfig):
kernel/sched/core.c: In function ‘sched_submit_work’:
kernel/sched/core.c:6346:35: error: ‘struct task_struct’ has no member named ‘plug’
6346 | blk_flush_plug(tsk->plug, true);
| ^~
kernel/sched/core.c: In function ‘io_schedule_prepare’:
kernel/sched/core.c:8357:20: error: ‘struct task_struct’ has no member named ‘plug’
8357 | if (current->plug)
| ^~
kernel/sched/core.c:8358:39: error: ‘struct task_struct’ has no member named ‘plug’
8358 | blk_flush_plug(current->plug, true);
| ^~
I tested the latest block tree and did not see it fixed nor did I see it
reported or fixed elsewhere.
Cheers,
Nathan
