On 10/21/21 16:13, yukuai (C) wrote:
On 2021/10/21 20:35, Pavel Skripkin wrote:
On 10/21/21 15:29, Yu Kuai wrote:
Yu Kuai (2):
nbd: fix max value for 'first_minor'
nbd: fix possible overflow for 'first_minor' in nbd_dev_add()
drivers/block/nbd.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
Hi, Yu!
Thank you for the fix, but this wrong check should be just removed,
since root case of wrong sysfs file creation was fixed, as Christoph
said [1]
Hi, Pavel
Thanks for your response, with the root cause fixed, patch 1 is not
needed anymore. However, the overflow case in patch 2 is still
possible.
Does anyone plan to remove the checking?
Hm, I thought it was already removed, but I was wrong, I guess. Let's
see what Christoph thinks about this check.
Maybe add_disk() error handling is still not in Linus tree, I haven't
checked yet. Sysfs warnings _should_ be fixed by proper error handling,
but maybe there is another problem somewhere...
With regards,
Pavel Skripkin
